[docker-in-docker] - issue #1202 solution - moby=false, holds configured docker-ce and docker-ce-cli version - #1215
Merged
Daniel Doyle (ddoyle2017) merged 5 commits intoJan 28, 2025
Conversation
…holds configured docker-ce and docker-ce-cli version
Gaurav Saini (gauravsaini04)
marked this pull request as draft
December 13, 2024 09:58
Gaurav Saini (gauravsaini04)
marked this pull request as ready for review
December 18, 2024 04:14
|
Can this please be moved forward, as I'm also blocked in a slightly different use case compared to #1202 where I want to install multiple Docker versions into a dev container, activating only exactly one after another as needed. We want to use this to work on and test upgrade use cases. Currently, the unwanted upgrade makes installing a precise Docker version impossible as far as I can tell from my logs. |
Daniel Doyle (ddoyle2017)
approved these changes
Jan 28, 2025
Daniel Doyle (ddoyle2017)
left a comment
Daniel Doyle (ddoyle2017)
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks for adding this!
Gaurav Saini (gauravsaini04)
deleted the
docker-in-docker_issue_#1202_solution
branch
January 29, 2025 08:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #1202
Feature Name
Description
versionis not respected when moby is set tofalse#1202 , whenever moby was set to false in configured option while building the feature, it led to implicitly installing docker-compose-plugin, reinstalling the docker-ce and docker-ce-cli to an undesired version.changelog
Checklist